Skip to content

Add support for an external synchronous compiler to discrete and hybrid systems #3399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Aug 8, 2025
Merged

Add support for an external synchronous compiler to discrete and hybrid systems #3399

merged 22 commits into from
Aug 8, 2025

Conversation

BenChung
Copy link
Contributor

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@AayushSabharwal AayushSabharwal force-pushed the bc/external-synchronous branch 4 times, most recently from 76ccb08 to cb56357 Compare June 19, 2025 05:58
@AayushSabharwal AayushSabharwal force-pushed the bc/external-synchronous branch from 1534bd6 to ea917fc Compare July 7, 2025 10:03
@AayushSabharwal AayushSabharwal force-pushed the bc/external-synchronous branch 3 times, most recently from fe5eb65 to cc0d5da Compare August 7, 2025 16:54
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025 •
edited
Loading

Benchmark Results (Julia vlts)

Time benchmarks
master 600d723... master / 600d723...
ODEProblem 0.0803 ± 0.0068 s 0.0804 ± 0.0063 s 0.999 ± 0.11
init 0.061 ± 0.0014 ms 0.0638 ± 0.0018 ms 0.956 ± 0.035
large_parameter_init/ODEProblem 1.03 ± 0.008 s 1.05 ± 0.0026 s 0.985 ± 0.008
large_parameter_init/init 0.111 ± 0.0021 ms 0.111 ± 0.0025 ms 1 ± 0.03
mtkcompile 0.0342 ± 0.0014 s 0.0339 ± 0.0009 s 1.01 ± 0.048
time_to_load 4.83 ± 0.0098 s 4.83 ± 0.029 s 1 ± 0.0064
Memory benchmarks
master 600d723... master / 600d723...
ODEProblem 0.588 M allocs: 20 MB 0.587 M allocs: 19.9 MB 1
init 0.908 k allocs: 0.0479 MB 0.908 k allocs: 0.0479 MB 1
large_parameter_init/ODEProblem 4.31 M allocs: 0.167 GB 4.33 M allocs: 0.168 GB 0.994
large_parameter_init/init 1.75 k allocs: 0.0874 MB 1.75 k allocs: 0.0874 MB 1
mtkcompile 0.231 M allocs: 8.55 MB 0.235 M allocs: 8.69 MB 0.983
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025 •
edited
Loading

Benchmark Results (Julia v1)

Time benchmarks
master 600d723... master / 600d723...
ODEProblem 0.0918 ± 0.0052 s 0.0924 ± 0.0062 s 0.994 ± 0.088
init 0.058 ± 0.012 ms 0.0573 ± 0.012 ms 1.01 ± 0.3
large_parameter_init/ODEProblem 1.14 ± 0.027 s 1.14 ± 0.005 s 0.999 ± 0.024
large_parameter_init/init 0.101 ± 0.011 ms 0.101 ± 0.0099 ms 0.997 ± 0.15
mtkcompile 0.0377 ± 0.0018 s 0.0389 ± 0.0009 s 0.97 ± 0.052
time_to_load 5.29 ± 0.14 s 5.19 ± 0.062 s 1.02 ± 0.03
Memory benchmarks
master 600d723... master / 600d723...
ODEProblem 0.577 M allocs: 18.8 MB 0.578 M allocs: 18.7 MB 1
init 0.815 k allocs: 0.0318 MB 0.815 k allocs: 0.0318 MB 1
large_parameter_init/ODEProblem 4.41 M allocs: 0.16 GB 4.4 M allocs: 0.16 GB 1
large_parameter_init/init 1.66 k allocs: 0.0712 MB 1.66 k allocs: 0.0712 MB 1
mtkcompile 0.231 M allocs: 7.99 MB 0.235 M allocs: 8.13 MB 0.983
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

@AayushSabharwal AayushSabharwal force-pushed the bc/external-synchronous branch from cc0d5da to 7fb5a65 Compare August 7, 2025 17:29
BenChung and others added 15 commits August 8, 2025 14:30
@BenChung @AayushSabharwal
Early work on the new discrete backend for MTK
1ff286d
@AayushSabharwal
feat: retain original equations of the system in TearingState
ae8dd96
@AayushSabharwal
feat: allow namespacing statemachine equations
0778868
@AayushSabharwal
feat: propagate state machines in structural simplification
295a4ce
@BenChung @AayushSabharwal
Handle nothing updates better
6c0b055
@BenChung @AayushSabharwal
Redefine the discrete_compile interface a bit
069dc74
@BenChung @AayushSabharwal
Change the external synchronous signature to include the id/clock map
3fba60e
@AayushSabharwal
feat: add zero_crossing_id to SymbolicContinuousCallback
dd1746e
@AayushSabharwal
feat: add ZeroCrossing and EventClock from zero crossing
af42247
@AayushSabharwal
feat: subset variables appropriately in clock inference
8592fe2
@AayushSabharwal
feat: add hook during problem construction
d023478
@AayushSabharwal
fix: handle Union types in BufferTemplate
0f3cace
@AayushSabharwal
feat: rewrite clock inference to support polyadic synchronous operators
8b7e1f7 
and other cool stuff too
@BenChung @AayushSabharwal
Better support for multi-adic operators
bea6a41
@AayushSabharwal
refactor: replace is_synchronous_operator with `is_timevarying_oper…
00d7ae0 
…ator`
@AayushSabharwal AayushSabharwal force-pushed the bc/external-synchronous branch from 7fb5a65 to 600d723 Compare August 8, 2025 18:30
@AayushSabharwal AayushSabharwal marked this pull request as ready for review August 8, 2025 18:31
@AayushSabharwal AayushSabharwal merged commit 6f2bc1b into master Aug 8, 2025
44 of 51 checks passed
@AayushSabharwal AayushSabharwal deleted the bc/external-synchronous branch August 8, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenChung @AayushSabharwal